Skip to content

fix(notion): open article links in new tabs#3853

Open
qianzhu18 wants to merge 1 commit intotangly1024:mainfrom
qianzhu18:contrib/issue-3670-article-links
Open

fix(notion): open article links in new tabs#3853
qianzhu18 wants to merge 1 commit intotangly1024:mainfrom
qianzhu18:contrib/issue-3670-article-links

Conversation

@qianzhu18
Copy link
Copy Markdown

Summary

  • open external article links in a new tab by default
  • preserve explicit targets and existing rel tokens
  • keep non-http links such as mailto in the current tab

Testing

  • npm test -- --runTestsByPath tests/components/NotionLink.test.js
  • npx eslint components/NotionLink.js components/NotionPage.js tests/components/NotionLink.test.js

Notes

  • eslint still reports 2 pre-existing react-hooks warnings in components/NotionPage.js

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 16, 2026

@qianzhu18 is attempting to deploy a commit to the tangly1024's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant